feat: add button text labels for accessibility #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replace SettingActionButton with AnimationSettingButton in GroupNotify and NotifyHeader components 2. Add text labels "Fold" and "More" to buttons using qsTr for translation support 3. Update translation files across 20+ languages to include new text entries 4. Improve XML formatting in translation files with proper encoding and line breaks 5. Add Chinese translations for new button labels while marking other languages as unfinished These changes enhance accessibility by providing text labels for icon- only buttons, making the interface more user-friendly for screen readers and users who prefer text labels. The component switch to AnimationSettingButton suggests improved visual feedback for button interactions. feat: 为可访问性添加按钮文本标签 1. 在 GroupNotify 和 NotifyHeader 组件中将 SettingActionButton 替换为 AnimationSettingButton 2. 使用 qsTr 为按钮添加"折叠"和"更多"文本标签以支持翻译 3. 更新20多种语言的翻译文件以包含新的文本条目 4. 改进翻译文件的 XML 格式，使用正确的编码和换行符 5. 为新的按钮标签添加中文翻译，同时将其他语言标记为未完成 这些更改通过为仅图标按钮提供文本标签来增强可访问性，使界面对屏幕阅读器和 偏好文本标签的用户更加友好。切换到 AnimationSettingButton 组件表明改进了 按钮交互的视觉反馈。 Pms: BUG-283585 BUG-283567
deepin pr auto review根据提供的git diff，我来分析一下代码变更并提出改进建议：
总体来说，这次改动提高了界面的可用性和可访问性，但需要确保翻译工作的完整性，并注意保持代码格式的一致性。 |
Reviewer's GuideThis PR enhances accessibility by replacing icon-only buttons with animated buttons that include translatable text labels, and updates translation files (adding new entries and improving XML formatting) across 20+ languages, with Chinese translations completed and others marked unfinished. Class diagram for button component changes in notification centerclassDiagram
class SettingActionButton {
}
class AnimationSettingButton {
+icon.name
+text
+onClicked()
}
class GroupNotify {
+AnimationSettingButton (Fold)
+AnimationSettingButton (More)
}
class NotifyHeader {
+AnimationSettingButton (Fold)
+AnimationSettingButton (More)
}
SettingActionButton <|-- AnimationSettingButton
GroupNotify o-- AnimationSettingButton
NotifyHeader o-- AnimationSettingButton
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `panels/notification/center/translations/org.deepin.ds.notificationcenter_az.ts:7-8` </location>
<code_context>
<source>Clear All</source>
<translation type="unfinished"></translation>
</message>
</code_context>
<issue_to_address>
**issue (bug_risk):** Translation for 'Clear All' in Azerbaijani uses Arabic text.
The current translation is in Arabic, not Azerbaijani, and should be corrected to avoid user confusion.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
BLumia
approved these changes
Sep 23, 2025
18202781743
approved these changes
Sep 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enhance accessibility by providing text labels for icon- only buttons, making the interface more user-friendly for screen readers and users who prefer text labels. The component switch to AnimationSettingButton suggests improved visual feedback for button interactions.
feat: 为可访问性添加按钮文本标签
这些更改通过为仅图标按钮提供文本标签来增强可访问性，使界面对屏幕阅读器和
偏好文本标签的用户更加友好。切换到 AnimationSettingButton 组件表明改进了
按钮交互的视觉反馈。
Pms: BUG-283585 BUG-283567
Summary by Sourcery
Add text labels for "Fold" and "More" buttons to improve accessibility, switch to animated buttons for enhanced visual feedback, and update translation files across 20+ languages with proper XML formatting and new entries, including Chinese translations.
New Features:
Enhancements: